search

scylladb / scylla-tools-java

Apache Cassandra, supplying tools for Scylla
Apache License 2.0
53 stars 85 forks source link

Cqlsh serverless v2 #323

Closed Lorak-mmk closed 1 year ago

Lorak-mmk commented 1 year ago

This PR adds serverless support for CQLSH. It was previosuly merged, but dtests later discovered a bug in python driver. The bug should be fixed now, so let's merge this again.

@fruch As you had more luck reproducing the issue with dtests than us, could you try and run them with this PR to make sure it works now?

Fixes https://github.com/scylladb/scylla-tools-java/issues/317 (again)

fruch commented 1 year ago

This PR adds serverless support for CQLSH. It was previosuly merged, but dtests later discovered a bug in python driver. The bug should be fixed now, so let's merge this again.

@fruch As you had more luck reproducing the issue with dtests than us, could you try and run them with this PR to make sure it works now?

i could try it out in Sunday, but mean time run it on scylla-ci to see its passing gating (it was noticed on some of the gating tests)

Fixes https://github.com/scylladb/scylla-tools-java/issues/317 (again)

Lorak-mmk commented 1 year ago

CI passed. @fruch did you have time to run those dtests?

fruch commented 1 year ago

CI passed. @fruch did you have time to run those dtests?

Didn't got to it, I'm compiling it now.

fruch commented 1 year ago

CI passed. @fruch did you have time to run those dtests?

Didn't got to it, I'm compiling it now.

I've run locally the two suites that were problematic, and didn't seen the issue:

./scripts/run_test.sh --scylla-version=5678  cql_cast_test.py json_test.py
avelanarius commented 1 year ago

pinging @scylladb/scylla-maint for merge