search

scylladb / scylla-tools-java

Apache Cassandra, supplying tools for Scylla
Apache License 2.0
53 stars 85 forks source link

bin/nodetool-wrapper: always forward help to java-nodetool #373

Closed denesb closed 6 months ago

denesb commented 10 months ago

Since scylla-nodetool already implements "help", nodetool help is routed to it. This results in command not yet implemented by scylla-nodetool getting an error, when one tries to get help for them. To avoid this, always forward help commands to the java nodetool.

Fixes: scylladb/scylladb#16669

denesb commented 10 months ago

Don't merge yet, v2 is coming.

denesb commented 10 months ago

Don't merge yet, v2 is coming.

Scrap that, this PR is good to go as-is.

tchaikov commented 10 months ago

might want to link to https://github.com/scylladb/scylladb/issues/16669 with the full path or use scylladb/scylladb#16669 instead of #16669 .

denesb commented 10 months ago

might want to link to scylladb/scylladb#16669 with the full path or use scylladb/scylladb#16669 instead of #16669 .

Fixed.

tchaikov commented 9 months ago

@scylladb/scylla-maint hello maintainers, could you help review and merge this change?

denesb commented 6 months ago

This has aged out, closing.