scylladb / scylla-tools-java

Apache Cassandra, supplying tools for Scylla
Apache License 2.0
53 stars 85 forks source link

Update JNA dependency to 5.14.0 #376

Closed mykaul closed 10 months ago

mykaul commented 10 months ago

Just compile-tested!

Fixes: https://github.com/scylladb/scylla-tools-java/issues/371

yaronkaikov commented 10 months ago

you can run locally ./reloc/build_reloc.sh and see if it's compiling

yaronkaikov commented 10 months ago

And it is

[yaronkaikov@london]~/git/scylla-tools-java (master)$ ../scylladb/tools/toolchain/dbuild 
bash-5.2$ ./reloc/build_reloc.sh 
Fedora 38 - x86_64                                                                                                                                                                                                            8.3 MB/s |  83 MB     00:09    
Fedora 38 openh264 (From Cisco) - x86_64                                                                                                                                                                                      2.6 kB/s | 2.5 kB     00:00    
Fedora Modular 38 - x86_64                                                                                                                                                                                                    428 kB/s | 2.8 MB     00:06    
Fedora 38 - x86_64 - Updates                                                                                                                                                                                                  9.6 MB/s |  36 MB     00:03    
Fedora Modular 38 - x86_64 - Updates                                                                                                                                                                                          189 kB/s | 2.1 MB     00:11    
Package ant-1.10.12-9.fc38.noarch is already installed.
Package java-1.8.0-openjdk-devel-1:1.8.0.382.b05-2.fc38.x86_64 is already installed.
Package python-unversioned-command-3.11.6-1.fc38.noarch is already installed.
Package ant-junit-1.10.12-9.fc38.noarch is already installed.
Package fakeroot-1.32.1-1.fc38.x86_64 is already installed.
Dependencies resolved.
Nothing to do.
Complete!
Buildfile: /home/yaronkaikov/git/scylla-tools-java/build.xml

init:

_resolver_download:

resolver-init:
[resolver:resolve] Resolving artifacts
[resolver:resolve] Resolving artifacts
[resolver:resolve] Resolving artifacts
[resolver:resolve] Resolving artifacts
[resolver:resolve] Resolving artifacts

write-poms:

init:

maven-ant-tasks-localrepo:

maven-ant-tasks-download:

_resolver_download:

resolver-init:

maven-ant-tasks-init:

maven-declare-dependencies:

_write-poms:

resolver-retrieve-build:
[resolver:resolve] Resolving artifacts
[resolver:resolve] Downloading https://repo1.maven.org/maven2/io/airlift/airline/0.9/airline-0.9.pom
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/io/airlift/airline/0.9/airline-0.9.pom (3 KB at 3.3 KB/sec)
[resolver:resolve] Downloading https://repo1.maven.org/maven2/io/airlift/airbase/93/airbase-93.pom
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/io/airlift/airbase/93/airbase-93.pom (66 KB at 276.7 KB/sec)
[resolver:resolve] Downloading https://repo1.maven.org/maven2/com/google/guava/guava/26.0-jre/guava-26.0-jre.pom
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/com/google/guava/guava/26.0-jre/guava-26.0-jre.pom (8 KB at 56.7 KB/sec)
[resolver:resolve] Downloading https://repo1.maven.org/maven2/com/google/guava/guava-parent/26.0-jre/guava-parent-26.0-jre.pom
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/com/google/guava/guava-parent/26.0-jre/guava-parent-26.0-jre.pom (11 KB at 72.5 KB/sec)
[resolver:resolve] Downloading https://repo1.maven.org/maven2/com/google/errorprone/error_prone_annotations/2.1.3/error_prone_annotations-2.1.3.pom
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/com/google/errorprone/error_prone_annotations/2.1.3/error_prone_annotations-2.1.3.pom (2 KB at 13.5 KB/sec)
[resolver:resolve] Downloading https://repo1.maven.org/maven2/com/google/errorprone/error_prone_parent/2.1.3/error_prone_parent-2.1.3.pom
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/com/google/errorprone/error_prone_parent/2.1.3/error_prone_parent-2.1.3.pom (5 KB at 37.2 KB/sec)
[resolver:resolve] Downloading https://repo1.maven.org/maven2/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.pom
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.pom (3 KB at 18.5 KB/sec)
[resolver:resolve] Downloading https://repo1.maven.org/maven2/org/codehaus/mojo/animal-sniffer-parent/1.14/animal-sniffer-parent-1.14.pom
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/org/codehaus/mojo/animal-sniffer-parent/1.14/animal-sniffer-parent-1.14.pom (5 KB at 32.4 KB/sec)
[resolver:resolve] Downloading https://repo1.maven.org/maven2/org/codehaus/mojo/mojo-parent/34/mojo-parent-34.pom
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/org/codehaus/mojo/mojo-parent/34/mojo-parent-34.pom (24 KB at 169.8 KB/sec)
[resolver:resolve] Downloading https://repo1.maven.org/maven2/net/java/dev/jna/jna/5.14.0/jna-5.14.0.pom
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/net/java/dev/jna/jna/5.14.0/jna-5.14.0.pom (2 KB at 14.8 KB/sec)
[resolver:resolve] Resolving artifacts
[resolver:resolve] Downloading https://repo1.maven.org/maven2/net/java/dev/jna/jna/5.14.0/jna-5.14.0.jar
[resolver:resolve] Downloading https://repo1.maven.org/maven2/io/airlift/airline/0.9/airline-0.9.jar
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/io/airlift/airline/0.9/airline-0.9.jar (79 KB at 210.3 KB/sec)
[resolver:resolve] Downloaded https://repo1.maven.org/maven2/net/java/dev/jna/jna/5.14.0/jna-5.14.0.jar (1835 KB at 2818.0 KB/sec)
[resolver:resolve] Resolving artifacts
    [unzip] Expanding: /home/yaronkaikov/.m2/repository/org/jacoco/org.jacoco.agent/0.7.5.201505241946/org.jacoco.agent-0.7.5.201505241946.jar into /home/yaronkaikov/git/scylla-tools-java/build/lib/jars

check-gen-cql3-grammar:

gen-cql3-grammar:

generate-cql-html:

generate-jflex-java:

build-project:
     [echo] apache-cassandra: /home/yaronkaikov/git/scylla-tools-java/build.xml

_build_java8_only:

_build_multi_java:
     [echo] Compiling for Java 8 (using /usr/lib/jvm/java-1.8.0-openjdk/bin/javac) ...
    [javac] Compiling 114 source files to /home/yaronkaikov/git/scylla-tools-java/build/classes/main
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
     [echo] Compiling for current java version ...

createVersionPropFile:
[propertyfile] Updating property file: /home/yaronkaikov/git/scylla-tools-java/src/resources/org/apache/cassandra/config/version.properties
     [copy] Copying 1 file to /home/yaronkaikov/git/scylla-tools-java/build/classes/main

build:

_main-jar:
      [jar] Building jar: /home/yaronkaikov/git/scylla-tools-java/build/apache-cassandra-thrift-666.development-20240111.24e5125914.jar
      [jar] Building jar: /home/yaronkaikov/git/scylla-tools-java/build/apache-cassandra-666.development-20240111.24e5125914.jar
      [jar] Building jar: /home/yaronkaikov/git/scylla-tools-java/build/scylla-tools-666.development-20240111.24e5125914.jar
      [jar] Building jar: /home/yaronkaikov/git/scylla-tools-java/build/apache-cassandra-clientutil-666.development-20240111.24e5125914.jar

stress-build:
    [javac] Compiling 6 source files to /home/yaronkaikov/git/scylla-tools-java/build/classes/stress
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 8
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: /home/yaronkaikov/git/scylla-tools-java/tools/stress/src/org/apache/cassandra/stress/CompactionStress.java uses unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 1 warning

resolver-dist-lib:
[resolver:resolve] Resolving artifacts
[resolver:resolve] Resolving artifacts

build-test:
    [javac] Compiling 4 source files to /home/yaronkaikov/git/scylla-tools-java/build/test/classes
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 8
    [javac] Note: /home/yaronkaikov/git/scylla-tools-java/test/unit/org/apache/cassandra/streaming/StreamingTransferTest.java uses or overrides a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 1 warning

jar:
      [jar] Building jar: /home/yaronkaikov/git/scylla-tools-java/build/tools/lib/stress.jar

BUILD SUCCESSFUL
Total time: 9 seconds
bash-5.2$ git diff
diff --git a/build.xml b/build.xml
index ec1aa475a6..6b60539cd3 100644
--- a/build.xml
+++ b/build.xml
@@ -426,7 +426,7 @@
                    <exclusion groupId="asm" artifactId="asm"/> <!-- this is the outdated version 3.1 -->
             <exclusion groupId="org.codehaus.jackson" artifactId="jackson-mapper-asl"/>
           </dependency>
-          <dependency groupId="net.java.dev.jna" artifactId="jna" version="4.2.2"/>
+          <dependency groupId="net.java.dev.jna" artifactId="jna" version="5.14.0"/>

           <dependency groupId="org.jacoco" artifactId="org.jacoco.agent" version="${jacoco.version}"/>
           <dependency groupId="org.jacoco" artifactId="org.jacoco.ant" version="${jacoco.version}"/>
bash-5.2$ 
mykaul commented 10 months ago

Yes, indeed!