scylladb / scylla-tools-java

Apache Cassandra, supplying tools for Scylla
Apache License 2.0
53 stars 85 forks source link

bin/nodetool-wrapper: pass all args to nodetool for testings its ability #378

Closed tchaikov closed 9 months ago

tchaikov commented 9 months ago

as the first argument is not necessary the subcommand. in some cases, the caller could pass "-p " or "-h " as the first option, or whatever it prefer. so feed "scylla nodetool" with all command line options to test is ability, use it only if it is able to handle all of them.

tchaikov commented 9 months ago

otherwise, we'd have

[2024-02-09T05:02:30.437Z] E               ccmlib.node.ToolError: Subprocess /jenkins/workspace/scylla-master/gating-dtest-release/scylla/.ccm/scylla-repository/17238/share/cassandra/bin/nodetool -h 127.0.12.1 -p 7199 -Dcom.sun.jndi.rmiURLParsing=legacy status exited with non-zero status; exit status: 100; 
[2024-02-09T05:02:30.437Z] E               stderr: error: unrecognized operation argument: expected one of ({cleanup, clearsnapshot, compact, compactionhistory, decommission, describering, disableautocompaction, disablebackup, disablebinary, disablegossip, drain, enableautocompaction, enablebackup, enablebinary, enablegossip, flush, getlogginglevels, gettraceprobability, help, listsnapshots, move, rebuild, refresh, removenode, scrub, setlogginglevel, settraceprobability, snapshot, statusbackup, statusbinary, statusgossip, stop, version}), got status
tchaikov commented 9 months ago

v2:

denesb commented 9 months ago

Submodule update: 2b1a569cb6cb841d5b7c0fb5ef7684ae98aabd14