search

scylladb / scylla-tools-java

Apache Cassandra, supplying tools for Scylla
Apache License 2.0
53 stars 85 forks source link

bin/cassandra-stress: Add extended version info #379

Closed k0machi closed 9 months ago

k0machi commented 9 months ago

This commit adds scylla-driver version reporting to cassandra-stress version subcommdand, to be included alongside main version. The version.properties parser was reworked to support arbitrary amount of additional properties, instead of just checking for CassandraVersion.

Task: scylladb/qa-tasks#1543

k0machi commented 9 months ago

The output now is as follows:

$  ./tools/bin/cassandra-stress version
Version: 3.11.13-SNAPSHOT
scylla-java-driver: 3.11.5.1
fruch commented 9 months ago

@k0machi please open an issue on this repository, and point to it.

It would be needed, if we want this to be backported.

mykaul commented 9 months ago

I'm unsure why I'm asked to review it. Generally, LGTM. I'd put the version in a single line, but it's a nit.

denesb commented 9 months ago

Submodule update: scylladb/scylla@f5245c18807d8b6f2880e5eeff6e46ddcc03e92c

fruch commented 9 months ago

Submodule update: scylladb/scylladb@f5245c1

thanks @denesb