dist: drop Java tools and change packaging just for cassandra-stress

scylladb / scylla-tools-java

Apache Cassandra, supplying tools for Scylla

Apache License 2.0

53 stars 85 forks source link

dist: drop Java tools and change packaging just for cassandra-stress #384

Closed syuu1228 closed 1 day ago

syuu1228 commented 8 months ago

Since Java based tools are deprecated and now we only need cassandra-stress, change package name to "scylla-cassandra-stress" and drop deprecated tools from the package.

Closes #370

denesb commented 8 months ago

I think https://github.com/scylladb/scylla-ccm/pull/565 has to go in, before we can merge this.

yaronkaikov commented 7 months ago

I think scylladb/scylla-ccm#565 has to go in, before we can merge this.

@denesb It was merged yesterday, can we merge this one?

denesb commented 7 months ago

I think scylladb/scylla-ccm#565 has to go in, before we can merge this.

@denesb It was merged yesterday, can we merge this one?

Not yet. The above PR was reduced in scope to just prepare ccm for the post JMX world. Throwing out all of Java on on go proved too big of a bite, to chew at once.

I just realized we also didn't yet finish https://github.com/scylladb/scylladb/issues/14856, notably, there are still dtests around testing the java tools. These need to be either:

Dropped altogether, if we decided we don't want/need a native replacement for the tested tool (e.g. sstableutil).
Rewrite the test to test the native variant. We are still lacking native variant to some of these (small ones but still).

syuu1228 commented 6 months ago

Rebased, since it was conflicted.

syuu1228 commented 5 months ago

I need to modify Obsoletes/Breaks/Replaces on this patch, since I supposed next release version is 5.5 so I wrote something like Replaces: %{product}-tools (<< 5.5) in this patch, but now we already released 6.0.

syuu1228 commented 5 months ago

Replaced << 5.5 with << 6.1.

roydahan commented 4 months ago

I think this one is not needed and this task https://github.com/scylladb/scylla-tools-java/issues/370 misled you.

We can/should keep the packaging as "scylla-tools-java" and c-s will be part of it. There is no need to separate it now after we separated it from Scylla.

So, the packaging can remain as scylla-tools-java but just not a dependency of scylladb.

yaronkaikov commented 1 week ago

@syuu1228 I guess we can continue with that now, right?

syuu1228 commented 1 day ago

I think this one is not needed and this task #370 misled you.

We can/should keep the packaging as "scylla-tools-java" and c-s will be part of it. There is no need to separate it now after we separated it from Scylla.

So, the packaging can remain as scylla-tools-java but just not a dependency of scylladb.

Okay, closing this PR.