do not include {dclocal_,}read_repair_chance if not enabled

scylladb / scylla-tools-java

Apache Cassandra, supplying tools for Scylla

Apache License 2.0

53 stars 85 forks source link

do not include {dclocal_,}read_repair_chance if not enabled #385

Closed tchaikov closed 6 months ago

tchaikov commented 6 months ago

dclocal_read_repair_chance and read_repair_chance could be missing if they are removed in newer Scylla releases, so ignore them and use 0.0 as the default values for them.

Refs scylladb/scylladb#3502

tchaikov commented 6 months ago

@scylladb/scylla-maint hello maintainers, could you help review this change?

denesb commented 6 months ago

What commands does this fix?

tchaikov commented 6 months ago

@denesb it's sstablelevelreset. the test failure can be found at https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/7814/testReport/junit/offline_tools_test/TestOfflineTools/Tests___dtest_with_topology_changes___test_sstablelevelreset/. this tool is not implemented yet. see https://github.com/scylladb/scylladb/issues/15038