search

scylladb / scylla-tools-java

Apache Cassandra, supplying tools for Scylla
Apache License 2.0
53 stars 85 forks source link

stress should use the NetworkTopologyStrategy by default, not SimpleStrategy #400

Closed bhalevy closed 4 months ago

bhalevy commented 4 months ago

Curreently stress uses SimpleStrategy as the default when creating the keyspace. This strategy is deprecated in scylla and it inhibits tablets, which require NetworkTopologyStrategy, so let's use the latter instead.

bhalevy commented 4 months ago

See https://github.com/scylladb/scylla-tools-java/blob/ef029b52bc7375393062bd2b4581f523ba76bdb1/tools/stress/src/org/apache/cassandra/stress/settings/OptionReplication.java#L38 and https://github.com/scylladb/scylla-tools-java/blob/ef029b52bc7375393062bd2b4581f523ba76bdb1/tools/stress/src/org/apache/cassandra/stress/settings/OptionReplication.java#L54

Though https://github.com/scylladb/scylla-tools-java/blob/ef029b52bc7375393062bd2b4581f523ba76bdb1/tools/stress/src/org/apache/cassandra/stress/settings/OptionReplication.java#L39 doesn't seem to support per-dc replication factors configuration so I'm not certain this is where we interpret the -schema option, and/or what stress uses to generate the args to CREATE KEYSPACE IF NOT EXIST...

bhalevy commented 4 months ago

@denesb is this something your team can own (and resolve :))?

bhalevy commented 4 months ago

@elcallio please fix this