scylladb / scylla-tools-java

Apache Cassandra, supplying tools for Scylla
Apache License 2.0
53 stars 85 forks source link

cassandra-stress: Make default repl. strategy NetworkTopologyStrategy #402

Closed elcallio closed 4 months ago

elcallio commented 4 months ago

Fixes #400

Switch default strategy to scylla preferred default.

bhalevy commented 4 months ago

@scylladb/scylla-tools-maint please merge

denesb commented 4 months ago

https://github.com/scylladb/scylladb/pull/19818

bhalevy commented 3 months ago

@dani-tweig can you please add backport labels for 6.1 and 6.2 (and we probably also need backport labels for enterprise branch in scylla-enterprise-tools-java)?

This needs backport to 6.1 and 6.0. Cc @denesb

denesb commented 3 months ago

@bhalevy why should we backport this? I need a scylla issue with a problem the this PR and the backport would fix.

bhalevy commented 3 months ago

@bhalevy why should we backport this? I need a scylla issue with a problem the this PR and the backport would fix.

The issue is https://github.com/scylladb/scylla-tools-java/issues/400.

We want to use NetworkTopologyStrategy by default for 2 reasons:

  1. To enable tablets for cassandra-stress when they are enabled by default - this is the motivation for the backport
  2. SimpleStrategy was deprecated a LONG time ago, and it's about time we stop using it by default in all of our tools (no other reason is really required) - this does not require backport.
denesb commented 3 months ago

Backports: