search

scylladb / scylladb-docs-homepage

Source for docs.scylladb.com site
https://docs.scylladb.com
0 stars 1 forks source link

docs: fix github repo links #13

Closed dgarcia360 closed 4 months ago

dgarcia360 commented 4 months ago

Motivation

Fixes the "open an issue" and "edit this page" buttons to point to this repository.

How to test

Clone the docs and try the buttons.

Considerations

Consider open-sourcing this repo so external users can open issues/ edit the page. Otherwise, we could link a separate repo for issues and hide the edit on this page button, as we did for the cloud docs. cc/ @annastuchlik

annastuchlik commented 4 months ago

@dgarcia360 Now clicking the button opens the correct repo, but it's looking for the default master branch, while the default branch in this repo is "main". How can we change it?

image

@tzach Can we make this repo public? I can't see any good arguments against it?

tzach commented 4 months ago

@tzach Can we make this repo public? I can't see any good arguments against it?

Yes, I do not see an issue either

dgarcia360 commented 4 months ago

@annastuchlik Good catch! Fixed in https://github.com/scylladb/scylladb-docs-homepage/pull/13/commits/c14b9d7da817cc44b238bcd949a7354f93c452c5

annastuchlik commented 4 months ago

@dgarcia360 Thanks! It works, so I'm merging it. Next, we'll make this repo public.