compaction manager: add a compaction type tag to all compaction metrics where possible

scylladb / scylladb

NoSQL data store using the seastar framework, compatible with Apache Cassandra

http://scylladb.com

GNU Affero General Public License v3.0

13.24k stars 1.26k forks source link

compaction manager: add a compaction type tag to all compaction metrics where possible #10150

Open vladzcloudius opened 2 years ago

vladzcloudius commented 2 years ago

Installation details HEAD: 680195564de7a54f5a6b2317a648a8e5671e1afe

Description This is a new feature request: add a compaction type (e.g. CLEANUP or RESHAPING) to all compaction metrics where possible, e.g. to scylla_compaction_manager_compactions.

Ref https://github.com/scylladb/scylla-monitoring/issues/1688

vladzcloudius commented 2 years ago

@raphaelsc @amnonh FYI

raphaelsc commented 2 years ago

@bhalevy FYI

raphaelsc commented 2 years ago

this feature is very important for improving observability of compaction activity. recently, I was debugging a resharding issue and I wasn't able to easily differentiante resharding activity from regular one.

bhalevy commented 2 years ago

Please ad an appropriate "Field-X" label

amnonh commented 10 months ago

@bhalevy @raphaelsc I'm going over Scylla Monitoring issues, what about this one?

raphaelsc commented 10 months ago

@bhalevy @raphaelsc I'm going over Scylla Monitoring issues, what about this one?

it's important, but we need to find some bandwidth for it.