search

scylladb / scylladb

NoSQL data store using the seastar framework, compatible with Apache Cassandra
http://scylladb.com
GNU Affero General Public License v3.0
13.65k stars 1.3k forks source link

Clean old and none relevant open PRs #21675

Open yaronkaikov opened 4 days ago

yaronkaikov commented 4 days ago

I have noticed that in the Scylladb repo, we currently have 263 open PR (based on master),

And about 125 of them are 6 months old or more (we have even a PR from 2019 :-)

please see https://github.com/scylladb/scylladb/pulls?q=is%3Aopen+base%3Amaster+created%3A%3C2024-02-14+

yaronkaikov commented 4 days ago

I would assume that PRs opened more than 3-4 months are not relevant

  1. We can/should notify PR owners when a PR is opened over X days (Month?)
  2. Close it if no actions in 2-3 months

@dani-tweig @avikivity @mykaul @roydahan does it sound reasonable ?

mykaul commented 4 days ago

I don't see the value in cleaning it. What's the motivation?

yaronkaikov commented 4 days ago

When we branch to new releases we often miss open PRs from being backported to new releases (because they are open), so we have added in our automation scan for all open PRs (based to master) so we can add the relevant label

having a lot of open PRs (which clearly no one use) doesn't make any sense and will just increase the time it will take us to scan those PRs