[perftune.py] 'tune' option from perftune.yaml is not keeping the order of the items

scylladb / seastar

High performance server-side application framework

http://seastar.io

Apache License 2.0

8.38k stars 1.55k forks source link

[perftune.py] 'tune' option from perftune.yaml is not keeping the order of the items #1842

Open ebenzecri opened 1 year ago

ebenzecri commented 1 year ago

After deploying a brand new cluster, I've compared the content of perftune.yaml and I've noticed the order of the items from tune option is not being kept.

Node A

cpu_mask: '0x0000ffff'
irq_core_auto_detection_ratio: 16
irq_cpu_mask: '0x00000101'
nic:
- ens5
tune:
- net
- system
tune_clock: true

Node B

cpu_mask: '0x0000ffff'
irq_core_auto_detection_ratio: 16
irq_cpu_mask: '0x00000101'
nic:
- ens5
tune:
- system
- net
tune_clock: true

ebenzecri commented 1 year ago

@vladzcloudius FYI

vladzcloudius commented 1 year ago

This inconsistency is due to this line: https://github.com/scylladb/seastar/blob/master/scripts/perftune.py#L1665

We simply need to sort the list. I'll check if there are other places like this and will send a patch. Thanks for reporting, @ebenzecri

vladzcloudius commented 1 year ago

The patch has been sent to a mailing list.