scylladb / seastar

High performance server-side application framework
http://seastar.io
Apache License 2.0
8.39k stars 1.55k forks source link

build: do not include -DBoost_TEST_DYN_LINK in seastar_testing_cflags #2509

Closed tchaikov closed 4 weeks ago

tchaikov commented 1 month ago

before this change, we include -DBoost_TEST_DYN_LINK in seastar_testing_cflags. but this macro is not documented by Boost document, what we should use is BOOST_TEST_DYN_LINK if we want to link against Boost.Test's shared library. see https://www.boost.org/doc/libs/1_86_0/libs/test/doc/html/boost_test/utf_reference/link_references/link_boost_test_dyn_link.html

the reason why the tests build, is that they pass

but either way, seasetar_testing is not supposed to expose this definition or `BOOST_TEST_DYN_LINK in its compile options.

in this change, we just drop this definition from cflags. as it is never checked by Boost.Test. And tests are supposed to define SEASTAR_TESTING_MAIN by themselves.

tchaikov commented 1 month ago

@scylladb/seastar-maint hello maintainers, could you help review this change?