build: allow CMake to find Boost using package config

tchaikov commented 1 week ago

Remove the "MODULE" parameter from find_package(Boost) call to allow using Boost's provided BoostConfig.cmake instead of CMake's FindBoost module. This aligns with CMake 3.30's policy CMP0167 which deprecates FindBoost.cmake.

Background:

We previously dropped our vendored FindBoost.cmake in bf684aca
CMake is deprecating its FindBoost module as Boost now provides its own package config files
Using Boost's config files is the recommended approach going forward

This change:

Silences CMP0167 policy warnings like CMake Warning (dev) at CMakeLists.txt:133 (find_package): Policy CMP0167 is not set: The FindBoost module is removed. Run "cmake --help-policy CMP0167" for policy details. Use the cmake_policy command to set the policy and suppress this warning.
Removes outdated comments about bundled FindBoost.cmake, which was removed in bf684aca02.
Enables using Boost's native package configuration

Refs bf684aca02

tchaikov commented 6 days ago

@scylladb/seastar-maint hello maintainers, could you help review this change?

tchaikov commented 21 hours ago

@scylladb/seastar-maint hello maintainers, could you help review this change?

scylladb / seastar

build: allow CMake to find Boost using package config #2537