search

scylladb / serverless-examples

Code examples for ScyllaDB Cloud Serverless platform.
Apache License 2.0
2 stars 2 forks source link

Rework Java example as a Maven project #8

Closed Bouncheck closed 1 month ago

Bouncheck commented 1 year ago

Reworked existing example to use maven to build. Path to the bundle can be passed as an argument and assembly plugin can be used to make a jar with needed dependencies (see README).

Bouncheck commented 1 year ago

I haven't tried running it with a bundle yet as I don't have any working bundle on me right now. Let me know if something here should be changed or added.

avelanarius commented 1 year ago

ping @rjeczalik (I will also review it)

rjeczalik commented 1 year ago

Thank you guys! @Bouncheck @avelanarius ❤️

annastuchlik commented 1 year ago

@rjeczalik @omrivardi @avelanarius @Bouncheck This PR is incomplete, as the example doesn't include TokeanAwarePolicy - see https://github.com/scylladb/siren-frontend/issues/3402.

You can either merge this PR and fix https://github.com/scylladb/siren-frontend/issues/3402 later, or @Bouncheck should update this PR before it is merged.

annastuchlik commented 1 year ago

Thanks @Bouncheck .

@rjeczalik @avelanarius Cloud your review this updated PR?