Maybe do not use &REST as a lexical variable

scymtym / architecture.builder-protocol

Protocol for flexible construction and traversal of results (e.g. ASTs in case of parsers)

GNU Lesser General Public License v3.0

8 stars 1 forks source link

Maybe do not use &REST as a lexical variable #2

Closed phoe closed 5 years ago

phoe commented 5 years ago

https://github.com/scymtym/architecture.builder-protocol/blob/8a7d2d4a18dd1581c0b748287489ee05fee4689a/src/protocol.lisp#L506-L509

I wouldn't consider it idiomatic to use members of LAMBDA-LIST-KEYWORDS for binding lexical variables - I was surprised to see it in the stack traces when Cleavir crashed on it at https://github.com/robert-strandh/SICL/issues/132