search

scytheStudio / SCodes

This project is Qt & Qml wrapper for ZXing-C++ Library that is used for decoding 1D and 2D barcodes.
https://scythe-studio.com/
Apache License 2.0
107 stars 36 forks source link

Join forces with upstream zxing-cpp? #17

Open axxel opened 2 years ago

axxel commented 2 years ago

Hi, I just noticed your project as I saw it mentioned in https://github.com/zxing/zxing. After realizing that it is based on "our" c++ fork, I was curious what you offered on top of my qt-example-code. I noticed that you copied part of it (thereby "accidentally" infringing on my copyright, by the way ;)) but opted to not use the QVideoFrame based ReadBarcode implementation and instead went for a video-frame -> QImage conversion way, which is definitively a bad idea in terms of performance and seems to have caused other issues (#13), too. May I ask why?

I'd like to encourage you to take part in this discussion and see if we can centralize the efforts of providing a good zxing experience to more people. What was missing that made you come up with your wrapper?

Besides that, you might want to update your build dependency to our latest 1.3 release (from today).

kosadev commented 2 years ago

Hi, at some point in 2019 we had a need to have a QR code scanner in one of our projects. It was long before publishing scodes wrapper. The idea was that at that point no Qt examples were actually working for us. They were either not compilable or they simply didn't want to scan. There were few developers working on that who are no longer part of the company. Sorry if it violated your copyrights. What would you like to do about that?

The main thing about this wrapper is to allow people easily and flawlessly get the library as the submodule and import it with just few steps: https://github.com/scytheStudio/SCodes#using At the time being, we plan to move it to Qt 6 as the Qt Multimedia module was re-architectured and changes will be probably massive.

axxel commented 2 years ago

Sorry for not responding to your last comment earlier. I just wanted to let you know that I upgraded the ZXingQtReader.h wrapper in our example directory to support Qt6 including the QML module.

axxel commented 9 months ago

I just noticed that you are still using the same upstream zxing-cpp version you did about 2 years ago (something around 1.2). I just released 2.2 which has substantial improvements all over the place compared to 1.2. This fact makes me wonder whether this project here is effectively abandoned?

So I'd like to invite you or anyone who comes across this and is interested in collaborating on a Qt wrapper to add their thoughts and requirements to this discussion.

BartoszSkorka commented 8 months ago

Hi @axxel,

Good news – we're now updating our project to the newer version of zxing-cpp 2.2. We also plan to address several issues related to SCodes. I want to assure you that the project has not been abandoned in any way. The main challenge has been the lack of time.