Fix deprecations in IC-2020.3

[sczerwinski]

Steps

1. Go to https://plugins.jetbrains.com/plugin/14843-wavefront-obj/versions
2. Run plugin verification with latest IDE version (203.*)

Result

IntelliJ IDEA Ultimate IU-203.5600.34 Compatible. 1 usage of scheduled for removal API and 3 usages of deprecated API

• 1 usage of scheduled for removal API Wavefront OBJ 0.1.2 uses API scheduled for removal in future releases
  • Scheduled for removal method usage (1)
  • FormattingModelBuilder.createModel(...) (1) (scheduled for removal in 2021.1) Deprecated method FormattingModelBuilder.createModel(...) is overridden in class ObjFormattingModelBuilder. This method will be removed in 2021.1
• 3 deprecated API usages Wavefront OBJ 0.1.2 uses deprecated API, which may be removed in future releases leading to binary and source code incompatibilities
  • Deprecated methods usages (3)
  • IconLoader.getIcon(String) (2) Deprecated method IconLoader.getIcon(String) is invoked in WavefrontObjIcons.<clinit>() Deprecated method IconLoader.getIcon(String) is invoked in ObjIcons.<clinit>()
  • CollectionsKt___CollectionsKt.max(Iterable) (1) Deprecated method CollectionsKt___CollectionsKt.max(Iterable) is invoked in GLModel.getSize()

Expected Result

Compatible

IDE Details

IntelliJ IDEA Ultimate IU-203.5600.34

[sczerwinski]

In ObjFormattingModelBuilder, change overridden createModel(...) method:

override fun createModel(formattingContext: FormattingContext): FormattingModel =
    FormattingModelProvider.createFormattingModelForPsiFile(
        formattingContext.psiElement.containingFile,
        ObjBlock(
            node = formattingContext.psiElement.node,
            spacingBuilder = createSpaceBuilder(formattingContext.codeStyleSettings)
        ),
        formattingContext.codeStyleSettings
    )

[sczerwinski]

IconLoader.getIcon(String) should be replaced with IconLoader.getIcon(String, Class), which specifies the class to be used to get a ClassLoader.

[sczerwinski]

Collection.max() should be replaced with Collection.maxOrNull().

[sczerwinski]

Changes to ObjFormattingModelBuilder require platform version 2020.3. Building with platform version 2020.3 requires Java 11.

[sczerwinski]

Also: PsiManager.addPsiTreeChangeListener(...)