Closed jason-neal closed 7 years ago
Hi, Thanks for pointing out and suggesting a fix! Merging the PR in its current form, setup.py stops working for me altogether. Yet, I think the approach is right. I will have a closer look asap. Cheers, Stefan
Solved in 0.11.0.
This checks what setup command is passed. If it is one of the info commands, (e.g. "egg_info") then
numpy
is not required and so is not imported for dependency determination . Allows dependency determination withoutnumpy
, thus resolving #22, allowing pip to installPyAstronomy
andnumpy
at the same time.Inspired by the
setup.py
file forscipy
.I have only tested it locally using a fresh conda enviroment (without
numpy
installed).Running
pip install -e .
fails.but with this PR
pip install -e . numpy --no-cache
works.When this is pushed to pypi this should allow
PyAstronomy
to be placed alongsidenumpy
in arequirements.txt
and be installed on fresh environments.