Closed skiehl closed 2 years ago
Hi, Thanks for reporting. Yes, this is true. This error appears to have been fixed recently and, as it seems, too recently to make it into the latest release. I will draft an updated release later today to get rid of this annoyance. Cheers
New version should contain fix.
In
pyTiming/pyPeriod/gls.py
the doc string of theGls
class says for thefreq
parameter:However, an error is raised
raise(ValueError("freq and fast cannot be used together."))
when the frequency is NOT given andfast=True
. The error is raised for the wrong conditions. In particular, with this implementationfast=True
can only be used with a manually provided frequency array, which is exactly the situation fast calculations should not work. Indeed, I in a quick testfast=True
andfast=False
gave inconsistent results, with a manually provided frequency array. Whereas, the results are consistent, when the same frequency array is provided manually, which would be automatically generated iffreq=None
.It looks like the error raising needs to be placed differently.