search

sczhou / ProPainter

[ICCV 2023] ProPainter: Improving Propagation and Transformer for Video Inpainting
https://shangchenzhou.com/projects/ProPainter/
Other
5.63k stars 665 forks source link

A bug or using the wrong package (training) #29

Closed Roowenliang closed 1 year ago

Roowenliang commented 1 year ago

Hi Mr. Zhou Thanks for answering my two questions. Got another one. I came across an issue at line #291 "if flows_f == 'None' or flows_b == 'None':" in trainer_flow_w_edges.py when I try to run the training code. The issue is that "flows_f" and "flows_b" are actually list, so flows_f == 'None' always return false even when "load_flow": is set to "0" in the json file. The training started running after changing that line to "if flows_f[0] == 'None' or flows_b[0] == 'None':"

Not sure if this issue is related to the python packages I'm using or not? Also is there any potential issues for the change "if flows_f[0] == 'None' or flows_b[0] == 'None':" ?

Thanks!

sczhou commented 1 year ago

Hi @Roowenliang , yes, you are right, it should be a bug, and you need to change flows_f, flows_b to flows_f[0], flows_b[0] .

I have fixed this bug, you can just pull the code. Thanks!

Roowenliang commented 1 year ago

Thanks! Awesome work.