search

sczhou / ProPainter

[ICCV 2023] ProPainter: Improving Propagation and Transformer for Video Inpainting
https://shangchenzhou.com/projects/ProPainter/
Other
5.6k stars 663 forks source link

Some bugs in resize_flow? #79

Closed longyangqi closed 6 months ago

longyangqi commented 6 months ago

I have some questions about the implementation of resize_flow in https://github.com/sczhou/ProPainter/blob/a39d634423fa0158a3119515a231a4df6390c972/utils/flow_util.py#L6-L11

As the flow should be [flow_x, flow_y]， why the flow multiplies newh / oldh in dim 0, and multiplies neww / oldw in dim 1?

Moreover, I am also confused about the usage of resize_flow in https://github.com/sczhou/ProPainter/blob/a39d634423fa0158a3119515a231a4df6390c972/scripts/compute_flow.py#L101-L102 why input (w_new, h_new) instead (h_new, w_new)? How can we correctly use the function resize_flow?

Looking forward to your reply, very thanks!

sczhou commented 6 months ago

Hi @longyangqi , I have fixed this bug. Thank you for pointing it out.