Add supercollider server status notification

scztt / LanguageServer.quark

16 stars 10 forks source link

Add supercollider server status notification #26

Closed jenshaase closed 2 months ago

jenshaase commented 3 months ago

Hi,

I added a new custom notification to the LSP. This notification will send status information about the Supercollider Server to the LSP client.

Once this is merged I can create another MR for the VSCode extension to show the data in the Status Bar. Here is already a preview:

grafik

scztt commented 3 months ago

Thanks for the PR jens! This is fantastic - I made a bunch of small nit-picky comments, but overall everything looks great, I'd love to get this merged.

jenshaase commented 3 months ago

@scztt I cannot see the comments you added. Do I miss anything?

scztt commented 3 months ago

@scztt I cannot see the comments you added. Do I miss anything?

Sorry, I think i did not submit them - can you see them now?

jenshaase commented 3 months ago

@scztt I can see them now. Thanks.

jenshaase commented 3 months ago

@scztt I fixed this PR now.