Closed okhick closed 1 year ago
Great PR, thanks for this.
Some of those keyboard shortcuts are already bound by default in vscode? Cmd+Enter has ~10 bindings on my system, and Cmd+Alt+T is definitely bound to the "Close Other Editors In Group" command.
I'm not sure how to deal with this, but here's an idea, let me know if you agree:
That's a good point. I was leaning towards bringing in what SuperCollier has and if it conflicted with someone's VSCode workflows they could remap. But that might have not been the best decision. I do agree that we should implement those "core" commands at the minimum.
Another option would be to chord the non-core commands. So like the help command would be cmd+k
cmd+d
.
I'm also fine leaving them empty. If someone really depends on a key command to, for example, dump the node tree they can easily map something that works.
After thinking about it I've opted to remove all of the non-core key bindings. The VSCode command pallet offers pretty quick access to the actual commands from the keyboard and it's easy to make one's own key bindings if they want.
Registers commands and key commands from the Server menu in SCIDE to push feature parity with SCIDE. Also adds key commands for
supercollider.evaluateSelection
,supercollider.evaluateRegion
,supercollider.evaluateLine
, andsupercollider.searchHelp
.Added commands are as follows:
supercollider.cmdPeriod
supercollider.showServerMeter
supercollider.showScope
supercollider.showFreqscope
supercollider.dumpNodeTree
supercollider.dumpNodeTreeWithControls
supercollider.showNodeTree
supercollider.startRecording
supercollider.pauseRecording
supercollider.stopRecording
Requires more commands to be added to the
ExecuteCommandProvider
in LanguageServer.quark. I opened a PR for that here.