sd012gfhkhhvh / Slate.AI

A Real Time Whiteboard for doodling with multiple peoples
https://slate-ai.vercel.app
MIT License
11 stars 16 forks source link

Bug/background updated #10

Closed rahul200367 closed 7 months ago

rahul200367 commented 7 months ago

7 Remove Background image from landing page

I agree to follow this project's Contributing Guidelines. Severity:

Critical Major Minor Trivial Describe the Bug: The background image in the landing page is implemented thoughout the entire site. This is a bug.

Video/Screenshots (mandatory)

.Room form login form .Joined room canvas

Checklist:

Are you contributing under any Open-source programme?

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slate-ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2024 8:44pm
sd012gfhkhhvh commented 7 months ago

You did it wrong.

  1. You remove the background from the entire site. You have to keep it inside the landing page.
  2. You did not follow the instructions of making PR.(you made pr to the main branch not in the dev branch)
  3. You did not follow the PR templete.

I am closing this issue. make sure to read the guidlines and discuss with me before making any future PR. take your time and figure it out.

rahul200367 commented 7 months ago

i have keep background in landing page .. its my first contribution sorry fot that.

sd012gfhkhhvh commented 7 months ago

i have keep background in landing page .. its my first contribution sorry fot that.

No bro you get it completely wrong. read my previous comment and try to understand. you need to keep the bg-image in the landing(home) page only not in the room-page.

and also read the contributing.md carefully. you made a wrong PR to the main branch, you need to create pr in the dev branch.

take your time and figure out. Let me know for any further help.