sd012gfhkhhvh / Slate.AI

A Real Time Whiteboard for doodling with multiple peoples

https://slate-ai.vercel.app

MIT License

11 stars 16 forks source link

Closed Hrx4 closed 7 months ago

Hrx4 commented 7 months ago

…ge #3

Title and Issue number

Title : FIX : invisible trail for rectangle and line Issue No. : #3

Code Stack :

Close #

[ x] I have mentioned the issue number in my Pull Request.
[ x] I have commented my code, particularly in hard-to-understand areas
[x ] I have gone through the contributing.md file before contributing
Additional context (Mandatory )

Are you contributing under any Open-source programme?

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
slate-ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 21, 2024 6:25am

sd012gfhkhhvh commented 7 months ago

@Hrx4 there are couple of issues in this pr.

You have made pr to the wrong branch(main) but you need to make pr on branch dev.
Your branch is not in sync with the main branch( it leads to conflicts while merging) (I will suggest you to go through the contributing.md and read the instaructions, ask me if there is any doubt.)
unwanted trails
trails are not visible to the room members in realtime.

use "git pull upstream main" in your featured branch your are working and then resolve the above issues.