sd012gfhkhhvh / Slate.AI

A Real Time Whiteboard for doodling with multiple peoples
https://slate-ai.vercel.app
MIT License
11 stars 16 forks source link

FIX : Invisible trails for Rectangle and Lines #20

Closed Hrx4 closed 6 months ago

Hrx4 commented 7 months ago

Title and Issue number

FIX : invisible trail for rectangle and line Title 👍 #3 Issue No. :

Code Stack :

Close #

Video/Screenshots (mandatory)

Checklist:

Are you contributing under any Open-source programme?

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slate-ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 7:47am
Hrx4 commented 7 months ago

@sd012gfhkhhvh Please review this. Now Its working fine in my system.

sd012gfhkhhvh commented 7 months ago

@sd012gfhkhhvh Please review this. Now Its working fine in my system.

I tested it locally But it still has defects. Please test it properly in your machine, and put a proper video of 2 users interacting in split screen view.

Though the trails are visible now but it has some crucial bugs -

  1. Eraser is not working anymore.
  2. elements drawn by one user vanishes in the other users window when the other user tries to draw something. HINT - (It's probably because of clearRect function used under useEffecct, As the other user doesnot have the elements drawn by another user in its own elements array it keeps only the elements drawn by him when you perform the foreach loop)

Try to clean the code a little, I can see two useEffects there with same functionalities. And there are no comments on your changes.

sd012gfhkhhvh commented 6 months ago

cloasing pr#20