JavidSumra commented 7 months ago

Title and Issue number

Title : Request for Eraser Resize Feature in Slate AI

Issue No. : #18

Close #18

Video/Screenshots:

https://github.com/sd012gfhkhhvh/Slate.AI/assets/112365664/6daf4392-a9b8-4bc1-aedc-8aa27463b79b

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have gone through the contributing.md file before contributing Additional context (Mandatory ) Description: Now, users have the ability to customize the eraser size according to their preferences by simply hovering over the "Eraser" icon. The eraser size can be adjusted dynamically, ranging from 1 to 100, providing a more flexible and user-friendly experience.

Changes:

Implemented resizable eraser functionality.
Added a range input to adjust eraser size.
Enhanced user interaction with the eraser icon.

Impact: This feature enhances the user interface and customization options for eraser functionality, allowing users to fine-tune their experience.

Are you contributing under any Open-source programme? I am Contributing Under JWOC 2024

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
slate-ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 23, 2024 7:26am

JavidSumra commented 7 months ago

Hey @sd012gfhkhhvh Sir Can You Please Add Respective Labels To this PR?

sd012gfhkhhvh commented 7 months ago

Screenshot 2024-01-22 201507

can you shift the popup a little to the right, otherwise it blocks the radio and its difficult to select in desktop view .

The remaining code is fine. I am thinking of creating a single dropdown/slider for all of the tools, just like ms paint, it has a single dropdown for size but has different options depending upon the selected tool. It would be more convenient rather than adjusting the size every time whiling selecting the tool. If you are interested doing that I can create a hard issue. let me know your thoughts.

AntonyJudeShaman commented 7 months ago

@sd012gfhkhhvh

can you shift the popup a little to the right, otherwise it blocks the radio and its difficult to select in desktop view .

The remaining code is fine. I am thinking of creating a single dropdown/slider for all of the tools, just like ms paint, it has a single dropdown for size but has different options depending upon the selected tool. It would be more convenient rather than adjusting the size every time whiling selecting the tool. If you are interested doing that I can create a hard issue. let me know your thoughts.

can u elaborate on this pls, like what features u expect

sd012gfhkhhvh commented 7 months ago

@sd012gfhkhhvh

can you shift the popup a little to the right, otherwise it blocks the radio and its difficult to select in desktop view . The remaining code is fine. I am thinking of creating a single dropdown/slider for all of the tools, just like ms paint, it has a single dropdown for size but has different options depending upon the selected tool. It would be more convenient rather than adjusting the size every time whiling selecting the tool. If you are interested doing that I can create a hard issue. let me know your thoughts.

can u elaborate on this pls, like what features u expect

Please refer to the Microsoft paint and observe how they handle sizing. There is a single dropdown for all tools and the optons under dropdown dynamically changes depending upon the tool selected.

sd012gfhkhhvh commented 7 months ago

@JavidSumra checked your PR . You did a great job, Its working fine with no conflicts. Kindly make pr to dev branch, you have made pr to the main branch by mistake.

sd012gfhkhhvh commented 7 months ago

@JavidSumra the feature I am talking about -

paint there is one single dropdown for selecting size for all the tool-strokes and eraser.

JavidSumra commented 7 months ago

Hey @sd012gfhkhhvh Sir I Changed Branch.

sd012gfhkhhvh commented 7 months ago

issue #18 has been resolved under pr#22 and merged sucsessfully.

AntonyJudeShaman commented 7 months ago

@JavidSumra the feature I am talking about -

there is one single dropdown for selecting size for all the tool-strokes and eraser.

i would like to work on this

JavidSumra commented 7 months ago

@JavidSumra the feature I am talking about -

there is one single dropdown for selecting size for all the tool-strokes and eraser.

i would like to work on this

Hey @AntonyJudeShaman I am Working on it already 😀

sd012gfhkhhvh / Slate.AI

Feature/eraser resize #22

Title and Issue number

Video/Screenshots:

Checklist: