sd012gfhkhhvh / Slate.AI

A Real Time Whiteboard for doodling with multiple peoples
https://slate-ai.vercel.app
MIT License
11 stars 16 forks source link

Bug/message persist #24

Closed JavidSumra closed 7 months ago

JavidSumra commented 7 months ago

Title and Issue number

Title : Store the Room chats locally in the browser.

Issue No. : #21

Close #21

Video/Screenshots (mandatory)

https://github.com/sd012gfhkhhvh/Slate.AI/assets/112365664/b80ef4ff-1c8f-4a3e-b4cf-83f69f177e37

Checklist:

Additional context (Mandatory ) Hey @sd012gfhkhhvh By Adding This PR I am Just Solving issue of Message Persistence But I Found One More issue is Messages Are Visible to all of Other Rooms Which Are Seprate.

Are you contributing under any Open-source programme? I am Contributing Under JWOC 2024

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slate-ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 0:14am
sd012gfhkhhvh commented 7 months ago

@JavidSumra I thing we don't need roomId in the server.js socket.on("message", ({ message, roomId })

and we also dont need useParam, kindly remove if they are irrelevant. The rest code is working fine, You lifted the state up to avoid data loose during re-render.

JavidSumra commented 7 months ago

Changes Done Sir @sd012gfhkhhvh

sd012gfhkhhvh commented 7 months ago

issue#21 has been resolved and pr#24 got merged successfully