search

sd1337 / adminlte-2-react

49 stars 24 forks source link

Issue with SideBar #8

Closed jasonna2607 closed 5 years ago

jasonna2607 commented 5 years ago

Hi, I think there's an issue with the Sidebar component.

It happens when the page is refreshed/redirected the second time.

sidebar

sd1337 commented 5 years ago

Looking at your screenshot, I assume that you are having a content height issue? Or is something else wrong? The height issue is related to how adminlte renders full screen (using some jquery code) and it does not work to well with the dynamic DOM generation of react. I thought I've already solved all issues but it seems not so

jasonna2607 commented 5 years ago

Well I’m not sure about that. It only happens if we re-render the dashboard page the second time (logout then login again) and the content height will back to normal again if we toggle something on the page (e.g open/closing of the inspect element tab of Chrome). Any idea on how to fix this?

juanruben commented 5 years ago

Hi. It happens to me that when logout and then login again, the sidebar disappear. If I refresh or resize the window, it renders again. It occurs in any browser

jasonna2607 commented 5 years ago

@juanruben I kinda solve it by setting the content-wrapper css's min-height to 100vh

juanruben commented 5 years ago

@jasonna2607 thanks! really worked in just one line. Hope it is solved in future versions

jasonna2607 commented 5 years ago

no problem 👍

juanruben commented 5 years ago

Hi @jasonna2607. Have you verified if this css trick works in production. For me it is fine in localhost, but in production it appears only if the window is resized forcing to re-render

juanruben commented 5 years ago

I make it !important and that's it. Thanks anyway

jasonna2607 commented 5 years ago

Yeap I made it !important

On Sat, 29 Jun 2019 at 2:01 AM, Juan Rubén Medina notifications@github.com wrote:

I make it !important and that's it. Thanks anyway

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sd1337/adminlte-2-react/issues/8?email_source=notifications&email_token=AGE65GINGQDFZLN5WK2ARHDP4ZGZHA5CNFSM4HWQWSW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2YZKA#issuecomment-506825896, or mute the thread https://github.com/notifications/unsubscribe-auth/AGE65GLGXG7UPLIGMDGUXU3P4ZGZHANCNFSM4HWQWSWQ .