sdague / amt

Python tools for interacting with Intel's AMT hardware control interfaces
Apache License 2.0
65 stars 30 forks source link

logging and exceptions #6

Open inhumanitas opened 8 years ago

inhumanitas commented 8 years ago

Hi. I want to use this lib to manage amt device. But some issues stops me to start:

1 When i'm connecting to device if login\pass is incorrect the main way to understand it is to compare result with 1. Why you did not raise any exceptions? In Client.init ,for example, make an auth checking request and raise errors.

2 And also there are print statements. It is better to use logging that i can disable out put if needed.

Can i make pull request to fix that issues or you have another opinion for each?

thx for library :)