search

sdailey / kiwi

Other
13 stars 1 forks source link

Block all internal IPs #1

Open stemid opened 9 years ago

stemid commented 9 years ago

I love your extension and I use it at work, where I might browse internal webpages a lot.

So your extension should have an option to ignore all hosts that resolve to internal IPs.

Edit: On second thought, this would be solved by an easy to use on/off feature. That way I can turn your extension on when I want to see community comments about a website. This would be much preferred over the current mode of operation.

sdailey commented 9 years ago

Wow I'm a horrible open sourcer - very sorry this went unnoticed.

What are some URL schemes that you'd like to see blocked? I have the code written to achieve this (https://github.com/sdailey/kiwi/blob/master/coffeescripts/background.coffee#L99), just need to know what schemes to add.

Thanks SO MUCH for the feedback. This is the first user issue derived from open source that I've ever been in charge of fixing! :D

Also: There is a Research Mode that can be toggled on/off with a Whitelist option, and an Auto-off timer, any of which you may find useful

stemid commented 9 years ago

I did notice you had a sort of blacklist in your code already, but it was static and hard coded to known sites.

You'll want to add a blacklist for all the internal IP subnets. https://www.ripe.net/manage-ips-and-asns/db/ipv4-blocks-for-private-internets

That would at least close this issue since my only problem is with intranet sites at work. You'd have to check the ip each URL resolves to first but I assume the browser already provides that information. That way you'll avoid checking for comments on any intranet site, whether they use internal DNS or not.

2015-08-17 6:01 GMT+02:00 sdailey notifications@github.com:

Wow I'm a horrible open sourcer - very sorry this went unnoticed.

What are some URL schemes that you'd like to see blocked? I have the code written to achieve this ( https://github.com/sdailey/kiwi/blob/master/coffeescripts/background.coffee#L99), just need to know what schemes to add.

Thanks SO MUCH for the feedback. This is the first user issue derived from open source that I've ever been in charge of fixing! :D

— Reply to this email directly or view it on GitHub https://github.com/sdailey/kiwi/issues/1#issuecomment-131674166.

Hälsningar / Greetings

http://Stefan.Midjich.name

sdailey commented 9 years ago

Sweet, I should be able to make this happen, adding to the todo list. Thanks a bunch, man!

In the interim - to address this: "Edit: On second thought, this would be solved by an easy to use on/off feature." you can take advantage of the Research Mode + Whitelist features. :)