sdaqo / anipy-cli

Little tool in python to watch and download anime from the terminal (the better way to watch anime). Also applicable as an API
https://sdaqo.github.io/anipy-cli
GNU General Public License v3.0
270 stars 40 forks source link

Configuring a different player via player_path which leads to mpv.exe on Windows side produces an error (WSL) #148

Closed GreatTeacherOni closed 9 months ago

GreatTeacherOni commented 9 months ago

Describe the bug Running command anipy-cli in bash produces following (yellow) error message: anipy-cli: error: Specified player `/mnt/c/path/to/dir/mpv-x86_64-v3-20231231-git-abc2a74/mpv.exe` is unknown which exits the app immediately

To Reproduce Steps to reproduce the behavior:

  1. Open /home/user/.config/anipy-cli/config.yaml and change value of "player_path" from mpv to /mnt/c/path/to/dir/mpv-x86_64-v3-20231231-git-abc2a74/mpv.exe (with or without " makes no difference in my tests) and save the file
  2. Run command anipy-cli in bash
  3. See error anipy-cli: error: Specified player `/mnt/c/path/to/dir/mpv-x86_64-v3-20231231-git-abc2a74/mpv.exe` is unknown

Expected behavior Bash command anipy-cli should start the app and ask what anime to search for.

Info pip show anipy-cli Name: anipy_cli Version: 2.7.28 Summary: Little tool in python to watch anime from the terminal (the better way to watch anime) Home-page: https://github.com/sdaqo/anipy-cli Author: sdaqo Author-email: sdaqo.dev@protonmail.com License: GPL-3.0 Location: /path/to/pyenv/lib/python3.12/site-packages Requires: beautifulsoup4, better-ffmpeg-progress, m3u8, moviepy, pycryptodomex, pypresence, python-dateutil, python-mpv, pyyaml, requests, setuptools, tqdm, yaspin Required-by:

Platform

Additional context Maybe this is not a bug but if I run following bash command: alias mpv="/mnt/c/path/to/mpv.exe" I can run mpv straight from WSL via following bash command: mpv /mnt/c/path/to/file (leads to file on Windows) OR mpv /path/to/file (inside Linux) OR mpv URL and all of them open the Windows MPV player without any issues

So this should be doable, since the windows mpv.exe accepts the same arguments (I'm using the mpv.exe 64bit file from https://sourceforge.net/projects/mpv-player-windows/files/64bit-v3/).

Would be nice if this feature would be implemented in case this is not a bug.

Before the question arises: I'm not using the mpv player which can be installed via apt since the video and audio stutters more often than not

sdaqo commented 9 months ago

should be fixed

sdaqo commented 9 months ago

the problem was the .exe, anipy cli did not account for that