sdaqo / anipy-cli

Little tool in python to watch and download anime from the terminal (the better way to watch anime). Also applicable as an API
https://sdaqo.github.io/anipy-cli
GNU General Public License v3.0
270 stars 40 forks source link

[Feature Request] Improve the search feature #175

Closed GreatTeacherOni closed 5 months ago

GreatTeacherOni commented 5 months ago

Describe the new feature A little QoL improvement for the search feature, which I got inspiration from ani-cli.

Here I was searching for "blue". This screenshot shows the output of ani-cli: image

This one shows the output of anipy-cli: image

Two things I would like to take from ani-cli: 1) The index numbers at the beginning starting from 1 2) The amount of episodes of that anime at the end of the line small improvements:

What problem are you trying to solve?

Do you have any ideas for implementation? Check how ani-cli does it. No need to reinvent the wheel

sdaqo commented 5 months ago

Index number, ok.

The other thing will not work, not every Provider gives us the amount of episodes when searching, we could fetch it for each anime but this would make the search very slow.

GreatTeacherOni commented 5 months ago

Regarding the "fetch amount of episodes"-part: How about you fetch that information on the backend and only from one (or maybe one backup) provider? Would that be doable?

Ani-cli does it like this I think: https://github.com/pystardust/ani-cli/blob/188030f01139acf48f0a3641d11890437cd783b1/ani-cli#L187C1-L193C2

Another idea: Show the sum of episodes that are shown in the "select episode"-list if that is easier

sdaqo commented 5 months ago

How about you fetch that information on the backend and only from one (or maybe one backup) provider? Would that be doable?

We support gogo and yugen, both do not give us information about the amount of episodes when searching, we only get that if we request that for each individual anime - this takes time. Even if we did have a provider that supports that, it would not make sense to implement this as it would just make the code more complex.

Show the sum of episodes that are shown in the "select episode"-list if that is easier

Again, with this we would need to fetch episodes for each anime individually.

Generally I do not really think this is that useful anyway, you get to see how many episodes the anime has when you select it anyway.