Closed DragonOfShuu closed 2 months ago
Oh no! I agree with nearly all of these changes; it clearly got wayy to late last night 💀. I'll go through and fix these, and see if I can spot any other potential issues
Haha, no worries, this is absolutely relatable
I went ahead and fixed all the issues outlined + more. However, I kept the download_component in a separate directory because I feel we have more parts of the CLI we can componentize
I went ahead and fixed all the issues outlined + more. However, I kept the download_component in a separate directory because I feel we have more parts of the CLI we can componentize
Awesome, thank you! I added a comment in the old review about the component things.
I have now moved the download component into the root dir!
This change addresses #193 and #196 by finding if the user has nothing new to download/watch, and notifies accordingly, instead of immediately crashing.
Not only that, but with the API you can now retry the download multiple times determined by a limit by the programmer. I implemented this because while I attempted to download anime, every 3 animes it errored while downloading, but I found if the API just retried, it would work again.
However, if retrying doesn't work, the API will just re-raise the error, meaning the programmer using the API can handle it from there. The CLI will now tell the user if there was an issue downloading, and will either skip downloading that episode, or it will just stop downloading that entire series (depending on the mode).
TLDR;