sdaqo / anipy-cli

Little tool in python to watch and download anime from the terminal (the better way to watch anime). Also applicable as an API
https://sdaqo.github.io/anipy-cli
GNU General Public License v3.0
270 stars 40 forks source link

Addresses #193 & #196 (cli notifies when nothing to download/watch on seasonals) +more #195

Closed DragonOfShuu closed 2 months ago

DragonOfShuu commented 2 months ago

This change addresses #193 and #196 by finding if the user has nothing new to download/watch, and notifies accordingly, instead of immediately crashing.

Not only that, but with the API you can now retry the download multiple times determined by a limit by the programmer. I implemented this because while I attempted to download anime, every 3 animes it errored while downloading, but I found if the API just retried, it would work again.

However, if retrying doesn't work, the API will just re-raise the error, meaning the programmer using the API can handle it from there. The CLI will now tell the user if there was an issue downloading, and will either skip downloading that episode, or it will just stop downloading that entire series (depending on the mode).

TLDR;

DragonOfShuu commented 2 months ago

Oh no! I agree with nearly all of these changes; it clearly got wayy to late last night 💀. I'll go through and fix these, and see if I can spot any other potential issues

sdaqo commented 2 months ago

Haha, no worries, this is absolutely relatable

DragonOfShuu commented 2 months ago

I went ahead and fixed all the issues outlined + more. However, I kept the download_component in a separate directory because I feel we have more parts of the CLI we can componentize

sdaqo commented 2 months ago

I went ahead and fixed all the issues outlined + more. However, I kept the download_component in a separate directory because I feel we have more parts of the CLI we can componentize

Awesome, thank you! I added a comment in the old review about the component things.

DragonOfShuu commented 2 months ago

I have now moved the download component into the root dir!