I'm just putting this out here in case it's something you might consider merging @sdatkinson. Although i expect it would be a rather controversial change.
I find the code style in this repo unusual in particular w.r.t to the use of _underscores (which seem to be used inconsistently for various things). I also don't like the this-> pointers for member access. It makes it painful to try and debug issues such as #49 . On this PR I have methodically gone through manually renaming things using camel case and mMember style, removing all the underscores and this-> occurrences. Free functions/Methods have a capital letter at the beginning. I probably missed some stuff. The 130 or so commits are rather sloppily named because it got super tedious but i tried to be careful and to give an indication of the one thing that I was changing in each commit. In some cases member variables that have very short names (e.g. in LSTMCell still have _ prefixes) since it looks ok there.
let me know if you think it is something you'd consider! I can clean it up a bit if there is some aspect you don't like or if you don't want to do this (I understand) and I'll just maintain a fork and try and keep it synced with your upstream changes.
I'm just putting this out here in case it's something you might consider merging @sdatkinson. Although i expect it would be a rather controversial change.
I find the code style in this repo unusual in particular w.r.t to the use of
_underscores(which seem to be used inconsistently for various things). I also don't like thethis->pointers for member access. It makes it painful to try and debug issues such as #49 . On this PR I have methodically gone through manually renaming things using camel case and mMember style, removing all the underscores and this-> occurrences. Free functions/Methods have a capital letter at the beginning. I probably missed some stuff. The 130 or so commits are rather sloppily named because it got super tedious but i tried to be careful and to give an indication of the one thing that I was changing in each commit. In some cases member variables that have very short names (e.g. in LSTMCell still have _ prefixes) since it looks ok there.let me know if you think it is something you'd consider! I can clean it up a bit if there is some aspect you don't like or if you don't want to do this (I understand) and I'll just maintain a fork and try and keep it synced with your upstream changes.