[BUG] Incorrect parameter name `i_end` in `dsp::Conv1D::process_()` - Githubissues

sdatkinson / NeuralAmpModelerCore

Core DSP library for NAM plugins

MIT License

304 stars 61 forks source link

[BUG] Incorrect parameter name `i_end` in `dsp::Conv1D::process_()` #104

Closed sdatkinson closed 4 months ago

sdatkinson commented 4 months ago

https://github.com/sdatkinson/NeuralAmpModelerCore/blob/bc51a12d2fc42193534836cba9b13aaaf99eb322/NAM/dsp.h#L135

i_end should be ncols like in the implementation:

https://github.com/sdatkinson/NeuralAmpModelerCore/blob/bc51a12d2fc42193534836cba9b13aaaf99eb322/NAM/dsp.cpp#L207