sdatkinson / NeuralAmpModelerPlugin

Plugin for Neural Amp Modeler
MIT License
1.9k stars 127 forks source link

[FEATURE] Stereo option to save CPU #190

Closed jimc4893 closed 1 year ago

jimc4893 commented 1 year ago

Most amp modelers have a stereo option so you can bus two mono guitar tracks into it. This would be fantastic.

damiangr commented 1 year ago

I'm strongly against it. Most amp modelers do not process amp in stero. You will double CPU utilisation in that case when you will use mono signal.

jimc4893 commented 1 year ago

It at least makes it easier when mixing, who doesn't double track everything nowadays?

damiangr commented 1 year ago

It at least makes it easier when mixing, who doesn't double track everything nowadays?

How it makes it easier.? Not every one pan double tracked guitars 100% L and R. It will only complicate things that you can easly do with another track in DAW if you need it.

With sterteo NAM i will have to use another Channel Mixing plugin if i wan to have less narrowed image. Nobody record doubled track to L or R. Most of users will record just another mono track.

I thing overcomplicate things is bad idea. You can alwas recod Two tracks put nam on both and route to one stereo guitar bus. SImple and effective.

If I want only one guitar track NAM will use twice CPU powet to process mono wave . This makes no sense to me.

But maybe you can elaborate how it makes mixing better with stereo version.

jimc4893 commented 1 year ago

A stereo option is default in many top amp sims, and works to be able to have double tracked guitars and edit their tone without clicking between two tracks and copy and pasting the instance after each change.

The advantage of this tool is to have amp capture modelling in a plugin, so making that more effective for projects that have 20 guitar tracks, all within 10 groups with two mono tracks each panned, it would make it more effective.

Not to mention good IR software are all designed to work with stereo input.. I wonder why that is..

damiangr commented 1 year ago

Most Amp simps ( like neural , ignite amps, amplitube can work on stereo track - yes but ams sim emulation will process mono input from L or R or mixed. They are not processing L and R independly. After AMP module yes - you have stereo processing with choruses , reversbs and so on. Can you give me some examples with Stereo amp sims?

jimc4893 commented 1 year ago

Ok so I will explain further with more detail now that you are changing the argument so that you can win it.

"Most amp modelers have a stereo option so you can bus two mono guitar tracks into it. This would be fantastic."

I am asking for MONO signals to be able to be sent into a STEREO plugin so that it can output STEREO audio from ONE amp.

Most IR software now such as GGD export their IRs as stereo by default, for all of the software that uses.. um... STEREO IR files.

musicalentropy commented 1 year ago

I use the stereo processing option in my other amp sims all the time, so I'd like to say I would be interested too in an additional option allowing to have stereo processing. It's useful in a lot of different contexts, not only for mixing, but also because some people like me use stereo effect plug-ins before and after the plug-in. And it's a bit akward to have to use two instances with the same parameters to do the same thing. Moreover, plug-ins allow an option to be set which defines if the plug-in can be opened in your DAW either as a mono or a stereo plug-in, so I don't see why such an option should be a regression.

BrunoDSL commented 1 year ago

Most Amp simps ( like neural , ignite amps, amplitube can work on stereo track - yes but ams sim emulation will process mono input from L or R or mixed. They are not processing L and R independly. After AMP module yes - you have stereo processing with choruses , reversbs and so on. Can you give me some examples with Stereo amp sims?

Amplitube 5 has a parallel routing option which gives you two signals which are independent from each other. Helix Native also has that option. I believe Amplifkation 360 also does it, but I can't confirm it.

musicalentropy commented 1 year ago

Amplifikation 360 has this option, TSE X50 too, same for Mercuriall amps, Nembrini, Neural DSP amp sims... By the way, Amplitube 5 has the worst workflow, as there is no direct way to use the same gear on left and right channels, you have to copy and paste gear + settings on each parallel path and it's very bad UX practice...

jimc4893 commented 1 year ago

no point responding to the guy who didnt understand how clear this request was, as we all did. lol

sdatkinson commented 1 year ago

Hey folks.

"Stereo" is tricky because there are at least 3 different things that people can be asking for.

I'll be breaking out this discussion out and we can address it piece by piece.

jimc4893 commented 1 year ago

"Stereo" is tricky because there are at least 3 different things that people can be asking for.

thanks steven. we just want 2 inputs and 2 outputs out of NAM, where the existing functionality is just duplicated for both L and R inputs. i have an idea of how to implement it into the code with my understanding of iPlug2 but it just involves duplicating the signal onto both L and R. and if there is a mono signal, ignoring the stereo section.

DomMcsweeney commented 1 year ago

+1 for the idea of 2 in / 2 out.

A) Having 2 ins and 2 outs would allow: Compatibility with stereo effects placed earlier in the signal chain before NAM. Compatibility with stereo audio / folder track operation - eg. Seperate L+R hard panned double-tracked guitars > one instance of NAM (a standard mixing technique)

B) Perhaps it could also potentially fix the current issues with the standalone app not working on channel 2 with interfaces that only have a Hi-Z on channel 2... but that's just a guess.

C) Stops people asking for it, sometimes repeatedly.

jimc4893 commented 1 year ago

C) Stops people asking for it, sometimes repeatedly.

i hear you, it'll shut me right up hah

sdatkinson commented 1 year ago

Summing a stereo input is in with #166.

Dual mono is being tracked in #108, so I'm going to close this as a duplicate and we'll continue there.