[BUG] Build Windows Failed -- Missing PlugIn.ico

[sdatkinson]

While attempting to build the v0.7.3 release with the Release-Native GitHub workflow, the Windows build failed on commit a4c187f.

The issue seems to be that D:\a\NeuralAmpModelerPlugin\NeuralAmpModelerPlugin\NeuralAmpModeler\build-win\NeuralAmpModeler.vst3\PlugIn.ico was not found. (Workflow step: Build Windows)

For comparison, this seems to have been fine in the v0.7.2 build, with only desktop.ini not being found. (Not finding desktop.ini seems not to have broken that build.)

I presume that figuring out what happened to PlugIn.ico will resolve this and we can get the next release built! 🙂

[sdatkinson]

Pinging @olilarkin in case you might be able to quickly see what might have happened, though I'll continue to dig and try to figure this out.

[sdatkinson]

Some findings:

Commit 11e86bd* ("commit A" for this Issue) works (Release Native 21).

Commit 7b40ace* ("commit C" / Release Native 19) doesn't.

There's a commit in between, 6080cfc* ("commit B"), that updates the iPlug2 submodule (#210). That commit itself doesn't build (Release Native 18) because .gitmodules wasn't updated. Commit C's only change is to fix that.

_*Not actually the commits themselves--I put a commit on top of each to enable the workflow_dispatch for the Release Native workflow._

[sdatkinson]

iPlug2 2b01ce (new) vs b1b9ac2 (old): diff.

Just changes to Examples and IGraphics...neither feels like what I was looking for:

[sdatkinson]

More thinking out loud:

• It's not finding D:\a\NeuralAmpModelerPlugin\NeuralAmpModelerPlugin\NeuralAmpModeler\build-win\NeuralAmpModeler.vst3\PlugIn.ico.
  • That looks like the destination %BundleDir%\PlugIn.ico from the icon copy
  • BundleDir is assigned the value %BUILD_DIR%\%NAME%.vst3
  • BUILD_DIR "D:\a\NeuralAmpModelerPlugin\NeuralAmpModelerPlugin\NeuralAmpModeler\build-win"
  • NAME "NeuralAmpModeler"
  • So D:\a\NeuralAmpModelerPlugin\NeuralAmpModelerPlugin\NeuralAmpModeler\build-win\NeuralAmpModeler.vst3 ✅

So

• File not found - D:\a\NeuralAmpModelerPlugin\NeuralAmpModelerPlugin\NeuralAmpModeler\build-win\NeuralAmpModeler.vst3\desktop.ini is line 39 failing?
• And File not found - D:\a\NeuralAmpModelerPlugin\NeuralAmpModelerPlugin\NeuralAmpModeler\build-win\NeuralAmpModeler.vst3\PlugIn.ico is line 45 failing?
• It can't be line 45/46 because the logs would be out of order for that?

Anyways, I think that the root cause is that %IconSource% doesn't exist, and I bet that I didn't see the failure because of the > NUL at the end of the line?

And that's %VST_ICON%, "D:\a\NeuralAmpModelerPlugin\NeuralAmpModelerPlugin\NeuralAmpModeler\projects\..\..\iPlug2\Dependencies\IPlug\VST3_SDK\doc\artwork\VST_Logo_Steinberg.ico

So I bet that if I look in the SDK, it won't be there?

Indeed, the README doesn't ask for it to be extracted.

Just downloaded vst-sdk_3.7.7_build-19_2022-12-12.zip from https://www.steinberg.net/developers/. I see VST_SDK/vst3sdk/doc/artwork/VST_Logo_Steinberg.ico. Good.

So, perhaps it's simply a question of making sure that this ends up where it was expected to be.

Looking into ./download-iplug-sdks.sh, it looks like the culprit is that the docs aren't cloned down--could fix by adding

git submmodule update --init doc

after this line.

...found it 🙂

[sdatkinson]

It worked!

Mac build is still broken though with a new issue?