sdatkinson / NeuralAmpModelerPlugin

Plugin for Neural Amp Modeler
MIT License
1.88k stars 127 forks source link

[BUG] Code sign and notarize macOS binaries, installer, dmg #365

Open olilarkin opened 1 year ago

olilarkin commented 1 year ago

Hey Steve,

the macOS NAM binaries are not getting code-signed and the installer is not getting notarized. They should be :-). This is probably the source of multiple user issues, including repeated permissions dialog for microphone access, not being able to browse for files in certain paths etc. Logic X on arm64 is especially sensitive.

here is a great article about how to do it: https://melatonin.dev/blog/how-to-code-sign-and-notarize-macos-audio-plugins-in-ci/

Here is a WIP Pr/Branch on the iPlug2OOS repo from which NamPlugin was started where I was working on adding it to the CI/CD scripts:

https://github.com/iPlug2/iPlug2OOS/pull/9

oli@mac /Library/Audio/Plug-Ins/Components$ codesign -dv NeuralAmpModeler.component
Executable=/Library/Audio/Plug-Ins/Components/NeuralAmpModeler.component/Contents/MacOS/NeuralAmpModeler
Identifier=NeuralAmpModeler
Format=bundle with Mach-O universal (x86_64 arm64)
CodeDirectory v=20400 size=7081 flags=0x20002(adhoc,linker-signed) hashes=218+0 location=embedded
Signature=adhoc
Info.plist=not bound
TeamIdentifier=not set
Sealed Resources=none
Internal requirements=none
oli@mac /Library/Audio/Plug-Ins/Components$ codesign -dv VirtualCZ.component
Executable=/Library/Audio/Plug-Ins/Components/VirtualCZ.component/Contents/MacOS/VirtualCZ
Identifier=com.PluginBoutique.audiounit.VirtualCZ
Format=bundle with Mach-O universal (x86_64 arm64)
CodeDirectory v=20400 size=4874 flags=0x0(none) hashes=145+3 location=embedded
Signature size=9079
Timestamp=30 Oct 2022 at 12:27:47
Info.plist entries=24
TeamIdentifier=686EDA2T8T
Sealed Resources version=2 rules=13 files=51
Internal requirements count=1 size=200
sdatkinson commented 8 months ago

You're right. I'm going to look at taking this up relatively soon.