search

sdatkinson / NeuralAmpModelerPlugin

Plugin for Neural Amp Modeler
MIT License
1.98k stars 132 forks source link

VST3 Crash in 0.7.6 (spotted with cubase) #407

Closed olilarkin closed 11 months ago

olilarkin commented 11 months ago

It seems that Cubase crashes when you load a model in 0.7.6.

With your patched version of iPlug2 I think it doesn't crash predictably each time but with the iPlug2/master where I have done further work on the RealtimeResampler [FKA NonIntegerResampler] class it crashes predictably each time (at least on my mac).

I believe I have tracked it down to a bug with where GetBlockSize() initially returns zero for VST3 in iPlug2. I've fixed that here. Since I wasn't able to reliably reproduce the crash with your branch, this is still a theory, but you could try cherry picking that commit to your iPlug2 fork (if you are not yet comfortable to merge #406) and see if it helps the users who are seeing crashes.

hope that helps!

DomMcsweeney commented 11 months ago

A user in the fb group (Sam Brashear) has uploaded a crashdump, here's the file:

https://drive.google.com/file/d/13DVKigkQ0jOEpQLHPRVdFXDF84_MSMlQ/view

sdatkinson commented 11 months ago

Thanks for this! I'm working to see if I can replicate the issue on my side and catch what you described above happening.

sdatkinson commented 11 months ago

Well, the bad news is that I can't get 0.7.6 to crash on Cubase.

I've implemented the change you recommended (as well as the correct zeroing of the input buffer array in the Lanczos sampler).

I'm going to have a look through the crash logs I've gotten just to see if there are any other hints there before sharing the new build.