search

sdatkinson / NeuralAmpModelerPlugin

Plugin for Neural Amp Modeler
MIT License
1.9k stars 127 forks source link

[BUG] Clicking noise on playback #418

Closed hellobendaniel closed 8 months ago

hellobendaniel commented 8 months ago

Describe the bug When a .nam file is loaded in the NAM plugin, a clicking noise is generated on playback, regardless of playhead position.

To Reproduce Steps to reproduce the behavior:

  1. Load .nam file into plugin
  2. Click play of recorded region
  3. Listen to the sweet sounds of what i'd describe as 'predator clicks'

Desktop (please complete the following information):

sdatkinson commented 8 months ago

Thanks for this!

I am not able to reproduce it on my side, but a possible explanation for this would be that there are samples that sometimes don't get written to during the resampling container's processing routine--see bullet 2 of https://github.com/iPlug2/iPlug2/issues/1038#issue-2044660490.

I believe that I've fixed this with PR #419, so if you're able to verify that that does it for you then we can call this closed.

mattgoings commented 8 months ago

I can verify that PR #419 fixed the issue for me!

sdatkinson commented 8 months ago

gonna close this as resolved!