sdatkinson / NeuralAmpModelerPlugin

Plugin for Neural Amp Modeler
MIT License
1.88k stars 127 forks source link

[BUG] Standalone allows for selecting buffer size not supported by interface #424

Open ghost opened 8 months ago

ghost commented 8 months ago

To Reproduce Steps to reproduce the behavior:

  1. Open NeuralAmpModeler
  2. Click on File, then Preferences
  3. Change buffer size
  4. See error

Expected behavior To be able to change the Buffer size so the Program stops crashing

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Yesterday I was messing around with Buffer Sizes. After changing it to 96 I heard a really weird sound and the Program crashed. Now everytime I open it or try to change any setting it keeps on crashing. I've uninstalled and reinstalled it many times but nothing seemed to work.

I've explained the error in the Neural Amp Modeler Facebook Group about 10 min ago and uploaded a Video of it happening.

This is the Link: https://www.facebook.com/groups/neuralampmodeler/posts/7014242751957821/?comment_id=7014277945287635&notif_id=1704796619308776&notif_t=group_comment

sdatkinson commented 8 months ago

You said you picked a buffer size of 96...Am I correct that your interface doesn't support 96-sample buffers?

ghost commented 8 months ago

Correct. I tried out different buffer sizes because I pretty much don't know anything about this kind of stuff! The Problem was that I wasn't even able to change back the buffer size, as it was always crashing. A member of the Facebook Group pointed out though, that I could change the buffer size inside the .ini File inside the N.A.M. folder. I did exactly that and it solved the Problem!

The people over at the Facebook Group still advised me to post this as a BUG in here, since I wasn't able to change any setting inside the standalone program without it crashing.

sdatkinson commented 8 months ago

Ok, good to know.

I'm going to mark this as an upstream bug since the iPlug2 framework is the part of the code that handles that dialog box; the right place for a fix would be there, not in this repo (and by extension, once it's fixed there this plugin (along with others who have made plugins on iPlug2) will inherit it 🙂 ).

If you wanted to check the Issues there and see whether this is a known bug you might consider sharing this bug there so that it's in front of the right eyes 👍🏻 .

apw100 commented 7 months ago

Since Neural Amp Modeler crashes when you try to change the settings, you can do this manually.

  1. Open a File Explorer window, open the View dropdown menu and make sure "Hidden Items" is checked.
  2. Then go to the following path "C:\Users\XXXX\AppData\Local\NeuralAmpModeler" (replace "XXXX" with your user account name).
  3. There should be a single file named "settings". Right click on this, select "Open With" and then select "Notepad"
  4. Now edit the settings and save the file.
  5. Don't forget to uncheck the "Hidden Items" box in your File Explorer view panel when you're done. NeuroFix