sdatkinson / NeuralAmpModelerPlugin

Plugin for Neural Amp Modeler
MIT License
1.98k stars 133 forks source link

Change Frequency on the EQ #49

Open fcoberrios opened 1 year ago

fcoberrios commented 1 year ago

Would be great to implement a way that the user is able to change the Frenquency (Central frequency - Hz) of every band of the current equalizer and the bandwidth (Q), and in the future to add or remove as many bands as posible by the user (With a minimum of 3 as a base)

Also, if posible, be able to add a pre eq with as many bands as needed by the user.

sdatkinson commented 1 year ago

Hey!

Sounds like a lot of flexibility 😅 I'll be upfront and say that this probably won't be something that I work on very soon (at least the "additional bands" bit. The frequency part I might do, but there are actually some little "tweaks" in how the EQ works that aren't quite like a normal biquad filter. For example, the Q of the mid knob changes depending upon whether it's adding (low Q) or subtracting (high Q) from the signal; I did this just based on my ear and the knowledge that wider boosts tend to sound a little more natural, but I did consider moving the frequency as well (as well as how many dB you could add vs cut).

Here's a partial workaround for the "bands" part of this at least: When you're looking to dial in the tone, you could load up an EQ plugin that does that in your DAW. If you're doing post-EQ and you've still got the original capture of the amp (or maybe just make a new one using the NAM model!) could re-bounce the capture signal with that EQ applied and train a new NAM model in order to "bake in" the EQ.

Hopefully this gets you where you want to in the meantime! But if someone comes along and wants to contribute by working on this I'd be happy to try and set them in the right direction 🙂

sdatkinson commented 1 year ago

Switching the EQ from post- to pre- is a more manageable bite though. I might be able to do that sooner.