search

sdatkinson / NeuralAmpModelerPlugin

Plugin for Neural Amp Modeler
MIT License
1.99k stars 134 forks source link

[BUG] Model info doesn't show when re-opening the UI #524

Closed sdatkinson closed 1 week ago

sdatkinson commented 2 weeks ago

To reproduce

Steps to reproduce the behavior:

  1. Load model
  2. Settings page [pic 1]
  3. Close UI
  4. Open UI
  5. Settings page [pic 2]

Screenshots

Pic 1:

image

Pic 2:

image

Seems like the controls are destructed when the UI is closed.

So a solution is to add a way to listen to have the model info control pull from the model info instead of having it push on model staging changes.

sdatkinson commented 2 weeks ago

Note to self: OnUIOpen(), SendControlMsgFromDelegate, OnMsgFromDelegate

marmal95 commented 2 weeks ago

A very simple fix would be to just call NAMSettingsPageControl::SetModelInfo inside NeuralAmpModeler::OnUIOpen. As controls are destructed but model seem to stay loaded and in current version SetModelInfo is only called after new model is loaded.