search

sdatkinson / NeuralAmpModelerPlugin

Plugin for Neural Amp Modeler
MIT License
1.9k stars 127 forks source link

C++ Code style #94

Closed olilarkin closed 1 year ago

olilarkin commented 1 year ago

@sdatkinson I know these things are all very subjective, but I find the code style rules that you've imposed on the C++ source code a bit strange and extremely painful to work with.

iPlug2's UI code uses a lot of lambdas and it's very hard to fit them in with the 80 char line limit.

Other gripes...

this-> used all over the place unnecessarily

void _Function() I find the underscore unsightly

sorry :-)

sdatkinson commented 1 year ago

No worries--I'm very unopinionated about what the style is as long as (1) there is a style and (2) it can be applied with a single command (see format.bash).

If you want to change things, all I ask is that it be as easy to enact as it currently is (i.e. running that script).

sdatkinson commented 1 year ago

🎉