search

sdatkinson / neural-amp-modeler

Neural network emulator for guitar amplifiers.
MIT License
1.72k stars 130 forks source link

[BUG] disagreement metadata is int instead of bool #432

Closed sdatkinson closed 2 weeks ago

sdatkinson commented 2 months ago

e.g.

image

Both should be false

Issue is in the Pydantic model defining it as int.

Rodolfo-S commented 1 month ago

Is this as simple as changing the type hinting in LatencyCalibrationWarnings class? https://github.com/sdatkinson/neural-amp-modeler/blob/d55ab734a640ca67c8e28451f6d56a359873e9ef/nam/train/metadata.py#L53

Because all places where disagreement_too_high is referenced it's treated as a bool.

https://github.com/sdatkinson/neural-amp-modeler/blob/d55ab734a640ca67c8e28451f6d56a359873e9ef/nam/train/core.py#L398

https://github.com/sdatkinson/neural-amp-modeler/blob/d55ab734a640ca67c8e28451f6d56a359873e9ef/tests/test_nam/test_models/test_exportable.py#L114

...etc

vossenv commented 1 month ago

@Rodolfo-S I believe that's correct, unless I'm missing something deeper wrt pydantic