sdatkinson / neural-amp-modeler

Neural network emulator for guitar amplifiers.
MIT License
1.72k stars 130 forks source link

Standardized trainer: Leave cab-fitting loss on all the time? #436

Open sdatkinson opened 3 weeks ago

sdatkinson commented 3 weeks ago

Instead of having cab modeling/fit_cab be an option, perhaps it should just be on all the time.

Pros:

Cons:

Seeking other insights about this--what other considerations are there?

sdatkinson commented 4 days ago

This would severely impact training on macOS with Apple Silicon due to the lack of support for MRSTFT loss on the accelerator.

I'm not going to ship this until I can improve the situation there. However, once that's fixed, I'll ship this (and users who want it back can use an extension)