search

sdboyer / gps

your dependencies have arrived
MIT License
270 stars 24 forks source link

Do not include ineffectual constraints in hash #125

Closed sdboyer closed 7 years ago

sdboyer commented 7 years ago

When SolveParameters.RootManifest contains a ProjectConstraint for a project that is present in any of the imports described in SolveParameters.RootPackageTree, that ProjectConstraint should not be included when computing the input hash, as it will have no bearing on the solver, and thus is equivalent to not being present at all. As a rule, we try to reduce all cases that we can determine will not bear on solving to the same base/zero case, in order to minimize the possibility of spurious hash conflicts.

sdboyer commented 7 years ago

Fixed in #139

sdboyer commented 7 years ago

Not actually done yet, see #143

sdboyer commented 7 years ago

done again/actually now